chore(cts): replace localhost at runtime #3806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
previously approved these changes
Sep 22, 2024
it would have been better to have a proxy or something but I didn't manage to make it work, this will do for now |
shortcuts
approved these changes
Sep 22, 2024
algolia-bot
added a commit
that referenced
this pull request
Sep 22, 2024
Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Because
network=hostdoesn't work properly on mac, we need to usehost.docker.internallocally andlocalhoston the CI.Instead of generating the tests with the correct host, we can guess it at runtime based on the
CIvar env, this means we don't need to generate the tests anymore to run locally, the same code can run anywhere now !Kotlin and ruby are a bit of a pain because the error message also contains the address, but we can replace it too.
I add to use a weird
%localhost%otherwise mustache interprets it as a variable, or kotlin interprets it as a regex reference.